This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
[SetupXP] The two styles for handling activation refusal
- From: "Max Bowsher" <maxb at ukf dot net>
- To: <cygwin-apps at cygwin dot com>
- Date: Sat, 19 Jul 2003 14:40:00 +0100
- Subject: [SetupXP] The two styles for handling activation refusal
Gary's current SetupXP patchset calls 2 member functions on page activation:
OnActivate (returns void), and OnAcceptActivation (returns bool). I think
this is unnecessarily messy. AFAICS, OnAcceptActivation only exists to
prevent the need to change the return type of the existing OnActivate
function.
I would very much prefer changing OnActivate to return bool, combining the
purpose of both functions. Yes, this does require changes in all derived
classes, but the changes are trivial, and the end result is a cleaner, more
logical API.
Max.