This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [SetupXP] PropertyPage::OnInit


On Sat, 2003-07-19 at 23:33, Max Bowsher wrote:
> I would like to propose NOT moving the global font settings into
> PropertyPage::OnInit, and consequently not requiring "Call base class
> OnInit()" changes in all derived classes.
> 
> Since the font settings are *already* set up to fail silently if the
> relevant control is not present, I don't think we need or should give
> derived classes the ability to override this, especially when it adds an
> extra burden, which could be accidentally omitted when a new page was
> created.

Max, I appreciate the reviews you are doing. May I suggest that
submitting the various component patches that make up Gary's work is the
best way to review each aspect of it...

Rob
-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]