This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: package proposal update: suite3270
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: cygwin-apps at cygwin dot com
- Date: Fri, 31 Oct 2003 19:16:38 +0100
- Subject: Re: package proposal update: suite3270
- References: <Pine.LNX.4.53.0310290946370.2524@gremlin.fruitbat.org>
- Reply-to: cygwin-apps at cygwin dot com
On Wed, Oct 29, 2003 at 09:56:28AM -0800, Peter A. Castro wrote:
> Hi All!
>
> Due to "popular" suggestion (well, from Max and Chuck :), I've change the
> names of the packages comprising Paul Mattes's 3270 emulator suite. All
> individual emulator packages have been prefixed with 'suite3270'. This
> will help group the suite together in the package selection list. This
> was a minor change to the build scripts and thus a new source package was
> created as well. Perhaps now someone will review (and vote for) it
> (Please? Pretty Please!?).
Ok, we have three votes, so I felt, I could review the package a bit.
> Here are the setup.hint files:
>
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270
The requires line uses the wrong package names. The leading "suite3270-"
is missing. Besides that, if the base package already requires to
download all other packages, the split would be unneeded. Did you
actually intend that?
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-common
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-c3270
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-pr3287
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-s3270
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-tcl3270
> http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270-x3270
The other setup files are ok, AFAICS. I'm just wondering what the base
package is good for. All packages require the -common package, but none
requires the base package.
> Here are the source and binary packages:
>
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-3.2.20-1-src.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-common-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-c3270-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-pr3287-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-s3270-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-tcl3270-3.2.20-1.tar.bz2
> http://www.fruitbat.org/Cygwin/suite3270/suite3270-x3270-3.2.20-1.tar.bz2
I really don't see what the suite3270-common package is good for. Couldn't
that be better thrown together with suite3270? Both packages are really small
and I don't see any gain in having a "base" and a "common" package.
Besides that, the documentation is in all packages still in /usr/doc.
Please move it to /usr/share/doc.
Another nit concerning the documentation. Each package creates its own
documentation subdirectory right below /usr/doc. So after installing
all packages, you have
/usr/doc/suite3270-3.2.20 -- empty!
/usr/doc/suite3270-common-3.2.20 -- empty!
/usr/doc/c3270-3.2.20/
/usr/doc/pr3287-3.2.20/
etc.
I would prefer to keep all documentation in one subdirectory
/usr/share/doc/suite3270-...
and all the above subdirectories below that, instead of polluting the
doc directory itself with so many subdirs for one base package.
I would also prefer to have only one common README file under
/usr/share/doc/Cygwin. Basically all these READMEs are the same, with
just tiny differences. Why not just one file which describes the
whole suite?
Otherwise the packaging looks ok to me.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.