This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Setup: more intuitive resizing controls + some dialogs


On Sun, 19 Oct 2003, Igor Pechtchanski wrote:

> On Thu, 16 Oct 2003, Igor Pechtchanski wrote:
>
> > On Thu, 16 Oct 2003, Frank Richter wrote:
> >
> > > On 16.10.2003 22:29, Robert Collins wrote:
> > > > Before further review, I'd like you to correct
> > > > such abuses of C++.
> > >
> > > Done.
> > >
> > > Also, this patch is a bit more useful than the last one - the Chooser
> > > now sizes with the window.
> > >
> > > - f.r.
> >
> > Okay, this does indeed give us a resizeable chooser -- yuppee!!!  The
> > header row still behaves weirdly under Win2k (i.e., it fixes on a
> > particular size and won't bulge until a scroll bar is touched after
> > switching views), but it's something that can be lived with.
> >
> > Once this gets accepted, it would be relatively easy to make most other
> > dialogs resizeable.  One problem, as I mentioned before, would be with
> > items that need to be centered.
> >
> > Frank, thank you *very much* for doing this.
> >         Igor
>
> Rob, BTW, when this patch gets accepted, I have an idea on how to modify
> this code to allow more intuitive control over the elements (e.g.,
> centering).  I'll also be able to make most of the other dialogs
> resizeable.
>         Igor

As promised.
	Igor
==============================================================================
ChangeLog:
2003-10-31  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

	* ControlAdjuster.h (ControlPosition): New enum type.
	(ControlInfo::horizontalPos, ControlInfo::verticalPos): New
	instance variables.
	(ControlInfo::anchorLeft, ControlInfo::anchorTop,
	ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
	* ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
	using position specifiers instead of anchors.
	* choose.cc (ChooserControlsInfo): Ditto.
	* proppage.cc (DefaultControlsInfo): Ditto.
	* propsheet.cc (PropSheetControlsInfo): Ditto.
	* site.cc (SiteControlsInfo): Position specifiers for site
	selection dialog controls.
	* threebar.cc (ThreeBarControlsInfo): Position specifiers for
	progress dialog controls.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

Attachment: setup-resizeable-finer-controls.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]