Re: Please upload: postgresql-8.0.0cvs-1 [test]

[Reini Urban <rurban at x-ray dot at>]

Gerrit P. Haase schrieb:

> Hello Reini,
>
> Am Dienstag, 5. Oktober 2004 um 11:42 schriebst du:
>
>
> > Gerrit P. Haase schrieb:
> >
> > > Am Dienstag, 5. Oktober 2004 um 04:25 schriebst du:
> > >
> > > > getting this when I try to build:
> > >
> > > Getting another one (missing -lpgport here?):
>
>
> > Yes.
> > I'm sure I had this in one version of my patches, but where is it gone ...
> > DLL's missing -lpgport on cygwin is my most concern to get fixed 
> > upstream, BTW. Besides tablespace and IPC.
>
>
> > > dlltool --export-all  --output-def ltree.def ltree_io.o
> > > ltree_op.o lquery_op.o _ltree_op.o crc32.o ltxtquery_io.o
> > > ltxtquery_op.o ltree_gist.o _ltree_gist.o
> > > dllwrap -o ltree.dll --dllname ltree.dll  --def ltree.def
> > > ltree_io.o ltree_op.o lquery_op.o _ltree_op.o crc32.o
> > > ltxtquery_io.o ltxtquery_op.o ltree_gist.o _ltree_gist.o
> > > ../../src/utils/dllinit.o -L../../src/port -L/usr/local/lib
> > > -L../../src/backend -lpostgres 
> > > lquery_op.o(.text+0x485):lquery_op.c: undefined reference to `_pg_strncasecmp'
> > > ltxtquery_op.o(.text+0x18c):ltxtquery_op.c: undefined reference to `_pg_strncasecmp'
> > > collect2: ld returned 1 exit status
> > > dllwrap: gcc exited with status 1
> > > make[1]: *** [libltree.a] Error 1
>
> > Add
> >   SHLIB_LINK += -lpgport
> > to the Makefile as last line.
> > For me it built without, strangely.
>
> Actually I added it to BE_DLLLIBS in Makefile.cygwin:
> BE_DLLLIBS= -L$(top_builddir)/src/backend -lpostgres -L$(top_builddir)/src/port -lpg_port

They will not accept this, though it makes sense to add -lpgport to the 
backend libs. In my first set of patches I did this also.

They decided recently to split modules into normal MODULES and 
MODULE_big, where big will get all the libs, and some contrib modules 
have wrong "Zuordnungen".
  src/makefiles/pgxs.mk
but then they turned off USE_PGXS and switched to
$(top_srcdir)/contrib/contrib-global.mk
I'll need some time to understand this.

> And another one, there is a missing CPPFLAG for the src/bin/psql
> directory 

> (at least for me, I'm building outside the source directory), 

Ah, good to to know, that I can try this also now. Didn't work last 
month. I don't believe that they know it also.

> I added -I$(top_srcdir)/src/bin/psql here in
> src/bin/psql/Makefile: 
>
> override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS) -I$(top_srcdir)/src/bin/psql -DFRONTEND

Thanks. I'll test and fix upstream.

--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/