This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] generic-build-script


On Wed, 22 Jun 2005, Max Bowsher wrote:

> Igor Pechtchanski wrote:
> > On Tue, 21 Jun 2005, Max Bowsher wrote:
> > > Hmm. It seemed sort-of elegant to me to just use ${PKG}-${VER},
> > > rather than defining another variable.
> > > I'd go with just a comment.
> >
> > Fair enough.  Want to resubmit the patch with the comment?
> >
> > > If not, how about names:
> > >
> > > BASEPKG
> > > CYGPKG_NV
> > > CYGPKG_NVR
> > >
> > > or
> > >
> > > BASEPKG
> > > SHORTPKG
> > > FULLPKG
> > > ?
> >
> > I like the latter, FWIW.  But we could go with ${PKG}-${VER} for now, and
> > factor it out into a variable later if it becomes a nuisance.
>
> As I considered the comment, I realized it was easier to explain if both
> had a name. So, I went with SHORTPKG.
>
> 2005-06-21  Max Bowsher  <maxb<at>ukf.net>
>
>        * generic-build-script (SHORTPKG): New variable.
>        (install): Use ${SHORTPKG} instead of ${BASEPKG} when referring to the
>        Cygwin package with the release number omitted, rather than the
>        upstream base package.

Thanks.  Applied with one tiny change:

> export BASEPKG=${PKG}-${VER}
> -export FULLPKG=${BASEPKG}-${REL}
> +export SHORTPKG=${PKG}-${VER}
> +export FULLPKG=${PKG}-${VER}-${REL}

+export FULLPKG=${SHORTPKG}-${REL}

I still think that it makes sense to define FULLPKG in terms of SHORTPKG.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"The Sun will pass between the Earth and the Moon tonight for a total
Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]