[PATCH] Update of "size" column patch for setup (Was Re: Is setup-2.506ready to release?)

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On Fri, 19 Aug 2005, Igor Pechtchanski wrote:

> On Fri, 19 Aug 2005, Brian Dessent wrote:
>
> > WRT to your patch that adds the size column, I would like to apply it
> > but I was hoping for a version that used MB instead of bytes, so that
> > the column is a little easier to read.  If you already posted that one
> > then please forgive me as I must have missed it.
>
> No, it's my fault -- I've been meaning to get back to it and fix it, but
> got sidetracked (though I was planning to use the "...k" formatting).
> I'll see what I can do in the next week or so.  FWIW, I'm not going to be
> particularly disappointed if it doesn't appear in the next release...

Ok, attached is a quick update to that patch -- please let me know if it
needs more work.  ChangeLog is at the end of this message.

> > Also, that change that makes it try bash instead of sh for scripts
> > should go in if we're about to release.

FWIW, I also have another patch, one that propagates the exit code of
postinstall scripts to setup.  It doesn't yet do anything about the exit
code, though.  I'll send that one out in a separate message.
	Igor
==============================================================================
ChangeLog:
2005-08-19  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

	* PickView.h (PickView::size_col): New instance variable.
	* PickView.cc (pkg_headers, cat_headers): Add size column.
	(PickView::set_headers): Initialize size_col.
	(PickView::init_headers): Include width of size column.
	* PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
	* String++.cc (format_1000s): New function.
	* String++.h (format_1000s): Declare new function.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA

Attachment: setup-package-size-column.patch
Description: Text document