Re: updated: guile-1.6.7-2, guile-1.7.2-2

[Jan Nieuwenhuizen <janneke at gnu dot org>]

Eric Blake writes:

> Sorry to be picky, but I noticed several nits in the packaging.

Thanks.  [I was building nit-free -3 versions just now]

> Your setup.hint mentions that depending on readline is useful although not
> a direct dependence, but then list libncurses7 and libreadline5 instead of
> the current libncurses8 and libreadline6.

Yes, I don't consider the guile command line, the only reason to
install the guile packages, really usable without readline.  Fixed.

> On the other hand, since they are not direct dependencies here, but
> libreadline6 IS a direct dependency of libguile12, you should
> probably only list libreadline6 in the libguile12 setup.hint, rather
> than here.

Why do you think that?

$ wine cygwin/root/usr/bin/cygcheck.exe cygwin/root/usr/bin/cygguile-12.dll
cygwin/root/usr/bin/cygguile-12.dll
  cygwin/root/usr/bin\cygcrypt-0.dll
    cygwin/root/usr/bin\cygwin1.dll
      C:\Windows\System\ADVAPI32.DLL
      C:\Windows\System\KERNEL32.dll
  cygwin/root/usr/bin\cygguile-ltdl-1.dll
Wine exited with a successful status

wine root/usr/bin/cygcheck.exe inst/guile-1.7.2-2-lib/usr/bin/cygguile-16.dll 
inst/guile-1.7.2-2-lib/usr/bin/cygguile-16.dll
  C:\cygwin\usr\bin\cygcrypt-0.dll
    C:\cygwin\usr\bin\cygwin1.dll
      C:\Windows\System\ADVAPI32.DLL
      C:\Windows\System\KERNEL32.dll
  C:\cygwin\usr\bin\cyggmp-3.dll
  C:\cygwin\usr\bin\cygintl-3.dll
    C:\cygwin\usr\bin\cygiconv-2.dll
  C:\cygwin\usr\bin\cygltdl-3.dll
Wine exited with a successful status

> Your binary package includes usr/share/doc/Cygwin/changelog.Cygwin, which
> is inappropriate for the Cygwin directory (that file, if distributed,
> should be in usr/share/doc/guile-1.6.7/).  Also, it should be
> usr/share/doc/guile-1.6.7/, not usr/share/doc/guile-1.6.7-2/.

Fixed.

> The source package includes generated files, such as autom4te.cache/, that
> add quite a bit of useless bulk.

Fixed.

> Have you considered using the generic-build-script?

I'm using mknetrel, plus plugings for split packages, doc and mingw
building.  Does the generic build script support cross building?

> Since guile-snarf and guile-tools are shell scripts, this setup.hint
> should also depend on bash (although this isn't critical, since bash is in
> the BASE package).

Ok, fixed.

> You may want to consider compressing the info files (most packages use
> gzip because of the current state of g-b-s, although bzip2 is probably okay).

Done.

>> http://lilypond.org/cygwin/uploads/guile/libguile12/setup.hint
>> http://lilypond.org/cygwin/uploads/guile/libguile12/libguile12-1.6.7-2.tar.bz2
>
> The setup.hint is missing several dependencies: crypt and readline6

>> http://lilypond.org/cygwin/uploads/guile/libguile16/setup.hint
>> http://lilypond.org/cygwin/uploads/guile/libguile16/libguile16-1.7.2-2.tar.bz2
>
> Here, the setup.hint is missing crypt and libint3.
                                                  ^L3
Fixed.

> I'm not sure whether
> .la files belong in usr/bin, or whether they should always be in usr/lib,
> but that may just be my misunderstanding of libtool.

AFAIK, on Cygwin .la files that are used by dlopen need to be in usr/bin.

Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org