This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: Multiple pending setup patches
On Thu, 13 Oct 2005, Brian Dessent wrote:
> Igor Pechtchanski wrote:
>
> > Technically, these packages *do* require bash, and coreutils, and possibly
> > others, so automatic dependency detection is hard (we don't want to have
> > setup parse shell scripts). Perhaps we should augment the "depends"
> > function of the g-b-s to also look at the postinstall script and find
> > packages for all commands invoked in it?
>
> Well hopefully, most (or all) of the coreutils commands will be plain
> binaries in /usr/bin, and not hard links or anything that requires
> fiddling from a postinstall. In other words, coreutils should be
> functional as soon as it's unpacked, so it doesn't really matter if
> package foo runs its postinstall before coreutils. In fact it doesn't
> even look like coreutils currently has a postinstall.
Right. But it may later. Some other things used in postinstall may
already have their own postinstall scripts. If we don't get the
dependencies correct now, it might make it harder in the future.
> Even still, because of the fact that it's in many "requires" lists
> coreutils is going to always be near the top of the "dependency sorted
> order list" anyway. I have a feeling that bash and coreutils will tend
> to "bubble up" to the top of it regardless, even if there are some cases
> where the explicit dependency in some packages is not spelled out.
That is certainly true. Perhaps we ought to have setup add both bash and
coreutils to dependencies of packages with postinstalls... But then, what
about sed, or tar?
> > * io_stream.cc (io_stream::open): Better log message on error.
> > (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
> > (io_stream::move,io_stream::exists): Ditto.
>
> Looks fine, go ahead. Better error messages are alwasy good. :-)
> Though I wonder if all those repeated throws should be a macro or inline
> instead...
Makes sense. I've committed a variant that uses a macro.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA