This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [g-b-s Patch: next try] Write and save logfiles for configure/make/check/install


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Igor Pechtchanski on 10/14/2005 8:20 AM:
> 
> One thing I didn't notice earlier about either this patch or your original
> one is that you removed the second "cd $(topdir)" from prep().  I know it
> looks superfluous, but it's there for a reason (so that unpack() can
> change directory with impunity -- yes, this happened to me before).
> 
> Applied, with that one change removed.  Thanks for the patch.  I'll
> address the above *.LOG issue shortly.
> 	Igor

This broke when following the directions at http://cygwin.com/setup.html
(that is, run mkdirs, spkg, then copy tarball to new location before
running pkg).  Running spkg when the log files don't exist should still work:

2005-10-15  Eric Blake  <ebb9@byu.net>

	* templates/generic-build-script (spkg): Don't fail if log files
	do not exist.

- --
Life is short - so eat dessert first!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDUQEt84KuGfSFAYARAgHIAJ9elsHsvtSJhPiapOPEvR3qwbtMMgCfV/M/
rwZ7ioXV6U7q+/0tbO3JL3M=
=Zht1
-----END PGP SIGNATURE-----
Index: templates/generic-build-script
===================================================================
RCS file: /cvs/cygwin-apps/packaging/templates/generic-build-script,v
retrieving revision 1.40
diff -u -p -r1.40 generic-build-script
--- templates/generic-build-script	14 Oct 2005 14:31:10 -0000	1.40
+++ templates/generic-build-script	15 Oct 2005 13:15:31 -0000
@@ -355,9 +355,10 @@ spkg() {
     cp $0.sig ${srcinstdir}/ ; \
   fi && \
   cd ${srcinstdir} && \
-  tar cvjf ${log_pkg_name} \
+  tar --ignore-failed-read -cvjf ${log_pkg_name} \
     ${configurelogname} ${makelogname} ${checklogname} ${installlogname} && \
-  rm ${configurelogname} ${makelogname} ${checklogname} ${installlogname} && \
+  rm -f ${configurelogname} ${makelogname} ${checklogname} \
+	${installlogname} && \
   tar cvjf ${src_pkg} * )
 }
 finish() {

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]