This is the mail archive of the cygwin-apps mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Ping? I'd like to apply this. Corinna, is that what you were envisioning? Would you like me to make a pre-compiled version available on the web to let people test without having to build? Igor On Wed, 28 Mar 2007, Igor Peshansky wrote: > On Thu, 22 Mar 2007, Brian Dessent wrote: > > > Corinna Vinschen wrote: > > > > > Question to the setup.exe maintainers: > > > > > > Do we really need the "Installation finished." message box at the end? > > > I find it increasingly annoying that I have to confirm the end of the > > > installation on a centered button when all the rest of the "OK" buttons > > > were at the bottom right of the prevous dialogs. > > > > > > Wouldn't it suffice to rename the "OK" button in the last dialog to > > > "Finish"? > > > > You're right, I hate that too and it's been on the todo list to remove > > this for a long time. > > And here is a patch. It does a bit more than remove the final mbox -- it > also moves the status information into the "Create Icons" dialog. It > should handle the resizing of that dialog correctly, but please test it > anyway. ChangeLog is below. Comments welcome. > Igor > ============================================================================== > ChangeLog: > 2007-03-28 Igor Peshansky <pechtcha@cs.nyu.edu> > > * LogFile.cc (LogFile::exit): Write exit_msg directly to log, without > the message box. > * resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New > control ids. > * res.rc (IDD_DESKTOP): Change the caption. Add status information. > * desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor > in the implementation. > * desktop.cc (DesktopControlsInfo): Position specifiers for status > information items. > (DesktopSetupPage::DesktopSetupPage): Register position specifiers. > (set_status): New static method. > (load_dialog): Set status information, if available. > (DesktopSetupPage::OnInit): Set status header font. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu | igor@watson.ibm.com ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for "nothing left to lose"... -- Janis Joplin
Attachment:
setup-remove-final-mbox.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |