This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [ATTN] patch: maintainer, please update to 2.5.9
* Mon 2008-02-18 Christopher Faylor <cgf-use-the-mailinglist-please-rDBXBDvO6BXQT0dZR+AlfA@public.gmane.org>
* Message-Id: 20080218163943.GC6084@ednor.casa.cgf.cx
> On Mon, Feb 18, 2008 at 08:25:30AM +0200, Jari Aalto wrote:
>
>>>>Would the package's maintainer ugrade to 2.5.9. The current does not
>>>>handle correctly patches/files that use CRLF line endings.
>>The original source package contain CRLFs, so diff against
>>is contains CRLFs as well.
>
> It's hard to see why a UNIX-based source package would contain CRLFs but,
> regardless, there shouldn't be any CRLFs in Cygwin packages.
There are windows developed software that has been ported to Linux.
Their developers use CRLF editors; hence the sources.
> I'm not arguing against changing patch but I'm cautioning you that if
> you, or anyone, are including source (or binary!) packages in the cygwin
> distribution which contain CRLFs that is a no-no.
Naturally.
I just encountered unfortunate situation, where I coulnd't apply the
diff against the original sources as usual. Getting around that was
more like "duct taping". I was uneasy with the measures I had to take
to get around it[*].
Jari
[*] The package was Lzma + patches
--
Welcome to FOSS revolution: we fix and modify until it shines