This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Setup.exe: allow -p option to specify categories as well as packages
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 4 Nov 2009 12:44:51 -0500
- Subject: Re: [PATCH] Setup.exe: allow -p option to specify categories as well as packages
- References: <4AF1BE4B.5090900@gmail.com>
- Reply-to: cygwin-apps at cygwin dot com
On Wed, Nov 04, 2009 at 05:47:55PM +0000, Dave Korn wrote:
>
> Last but not least,
>
> I found myself wanting to run setup in unattended mode to install absolutely
>everything, so I figured the nicest solution was to allow the -p option to
>accept category names as well as package names, so that I could use "-p All".
> The attached patch does just that.
>
> * package_meta.cc (packagemeta::isManuallyWanted): Allow category
> names as well as individual package names in packages_option.
> * package_db.cc (packagedb::fillMissingCategory): Don't check for
> manually-wanted packages until after initialising all the categories.
>
> Tested by running it a few times with no -p options and then with -p options
>for things like "Net" and/or a couple of individual packages mixed in. OK?
Unfortunately, no, I don't think so. I like the idea but I don't like overloading
"-p" as it could cause confusion. Why not add a new option entirely or some sort
of different syntax for categories like "Net:" or something?
cgf