Re: [ITP] lzip-1.8-1

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Nov 10 16:11, Corinna Vinschen wrote:
> On Nov 10 21:55, JonY wrote:
> > On 11/10/2009 17:43, Corinna Vinschen wrote:
> > >On Nov  9 21:03, JonY wrote:
> > >>http://www.cadforte.com/cygwin-uploader/lzip/lzip-1.8-1-src.tar.bz2
> > >>http://www.cadforte.com/cygwin-uploader/lzip/lzip-1.8-1.tar.bz2
> > >>http://www.cadforte.com/cygwin-uploader/lzip/setup.hint
> > >
> > >Packaging looks almost good.  The binaries in usr/bin are missing
> > >the .exe suffix for some reason.
> > >
> > >
> > >Corinna
> > 
> > Hi,
> > 
> > It was built and installed that way with cygport (Cygwin 1.7), the
> > provided non-autotools build system for lzip was originally designed
> > for Linux, eg "g++ -o bar foo.o".
> > 
> > I think it has something to do with the rename() thing, but
> 
> That would be a bit surprising.  I'm wondering what `make install'
> does in this package since something like
> 
>   install -s -m755 foo.exe $(bindir)/foo
> 
> will create a foo.exe file in $(bindir).  You should really check
> what happens.  If it's a problem in Cygwin 1.7, I'd rather like to
> know about it.

Uh, I see.  If you install without stripping, and the $(EXEEXT) is
missing in the target, you get the file w/o .exe suffix:

  install -m 755 foo$(EXEEXT) $(bindir)/foo

That's necessary, otherwise you would never have a chance to rename
an executable so that it has no suffix.

So, for portability, it would make sense to change the Makefile to
add $(EXEEXT) to the install target as well:

  install -m 755 foo$(EXEEXT) $(bindir)/foo$(EXEEXT)


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat