This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Another setup.exe infinite loop in unattended mode.


On Sun, Nov 22, 2009 at 03:51:07AM +0000, Dave Korn wrote:
>
>    Hi,
>
>  I found another one.  In unattended mode, if the setup.ini download or
>signature verification fails, we can loop forever trying again, because
>there's no user to select a different mirror.  A parallel problem exists if we
>try and install from a local package dir with no or a corrupt setup.ini file.
> The first case is worth retrying a few times, because it might just be a
>network glitch; the second not.
>
>  (Note that this all only kicks in if *all* the selected mirrors / local
>package dir setup.ini files are invalid.)
>
>	* threebar.cc (ThreeBarProgressPage::OnMessageApp): Don't loop forever
>	retrying ini file download/parse if it errors in unattended mode.
>
>  Ok?

Yep.  Looks good.  Thanks.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]