This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: setup.exe: Support xz and lzma decompression via liblzma


On 3/13/2010 6:06 AM, Corinna Vinschen wrote:
> On Mar 10 23:41, Charles Wilson wrote:
>> As posted, compress_xz.cc has a small number of msg() calls, which send
>> information to OutputDebugString. Some of these might need to be changed
>> to note() [e.g. MessageBox] or maybe removed entirely.  Or left as is.
>> Opinions?
> 
> AFAICS, the other compress_foo::read calls basically only return -1.
> So, either msg or nothing at all looks fine.

Is that an approval for the whole patch, or simply a comment on the
msg() vs. note() vs. [] issue?

--
Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]