This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] inform user if any postinstall script failed to run
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Sat, 28 Aug 2010 12:40:15 -0400
- Subject: Re: [PATCH] inform user if any postinstall script failed to run
- References: <4C49D54B.1030900@dronecode.org.uk> <20100723184920.GB9768@ednor.casa.cgf.cx> <4C503DCD.5020508@dronecode.org.uk> <20100728145822.GA9785@ednor.casa.cgf.cx> <4C51AC12.60005@dronecode.org.uk> <4C77F2BA.6030400@dronecode.org.uk> <20100827183333.GA6393@ednor.casa.cgf.cx> <4C79017E.2040507@dronecode.org.uk>
- Reply-to: cygwin-apps at cygwin dot com
On Sat, Aug 28, 2010 at 01:30:54PM +0100, Jon TURNEY wrote:
>On 27/08/2010 19:33, Christopher Faylor wrote:
>> On Fri, Aug 27, 2010 at 06:15:38PM +0100, Jon TURNEY wrote:
>>> On 29/07/2010 17:28, Jon TURNEY wrote:
>>>> On 28/07/2010 15:58, Christopher Faylor wrote:
>>>>> On Wed, Jul 28, 2010 at 03:25:17PM +0100, Jon TURNEY wrote:
>>>>>> Anyhow, here's another attempt, which unfortunately changes rather more than I
>>>>>> wanted to. It adds a new page, which is displayed if any script failed, and
>>>>>> reports which packages and scripts failed.
>>>>>
>>>>> That is great. Please check in (with a ChangeLog of course).
>>>
>>> Due to the way I tested this change, I'd failed to notice that when a package
>>> is installed with a failing postinstall script, this will list the failing
>>> script twice, once with the package name and once as 'no package'.
>>>
>>> Attached is a patch to remedy that.
>>
>> Do we realy need a separate for loop for this? Couldn't we just piggy
>> back on the previous for loop?
>
>Sure. I'm not sure if it's any more elegant, though :-)
Yow. No, it isn't. I didn't think you'd need to modify RunScript to
deal with the behavior.
So, nevermind. The previous solution looks simpler. Please go ahead
with that one.
cgf