This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rebase] Make rebase 64 bit capable (was Re: [patch/rebase] Make imagehelper 64-bit capable)


On Jul  7 13:48, Eric Blake wrote:
> On 07/07/2011 01:43 PM, Corinna Vinschen wrote:
> > -    printf ("%-47s base 0x%08lx size 0x%08lx\n",
> > +    printf (
> > +#if defined (__CYGWIN__) || defined (__MSYS__)
> > +	    "%-47s base 0x%08llx size 0x%08lx\n",
> > +#else
> > +	    "%-47s base 0x%08I64x size 0x%08lx\n",
> > +#endif
> 
> Do we need the #ifdef, or can we get away with including <inttypes.h>
> and doing:
> 
> printf ("%-47s base 0x%08" PRIx64 " size 0x%08lx\n")
> 
> and let PRIx64 take care of the ll vs. I64 spelling?

Much better.  Thanks for the hint.  I changed that locally.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]