This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 0/2] Make setup -q -P work as expected
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Sun, 14 Aug 2011 12:41:37 +0200
- Subject: Re: [PATCH 0/2] Make setup -q -P work as expected
- References: <1311340952-3288-1-git-send-email-jon.turney@dronecode.org.uk> <20110813075120.GA4098@calimero.vinschen.de> <4E468DCC.9090204@dronecode.org.uk>
- Reply-to: cygwin-apps at cygwin dot com
On Aug 13 15:44, Jon TURNEY wrote:
> On 13/08/2011 08:51, Corinna Vinschen wrote:
> >Hi Jon,
> >
> >On Jul 22 14:22, Jon TURNEY wrote:
> >>I'm somewhat reluctant to mess with this code as it is rather convoluted, so these
> >>patches could probably use some careful review and/or testing.
> >>
> >>But these patches attempt to make setup -q -P work more like the naive expectation [1]
> >>of just installing the specified package, rather than installing the specified package
> >>and upgrading all currently installed packages to the current version.
> >>
> >>Note that setup -q -L -P [2] probably sill doesn't work as expected, I'm guessing
> >>that without the benefit of a setup.ini, all packages found in the local package dir
> >>are placed in one of the special categories 'Base' or 'Misc' and thus always installed.
> >>
> >>[1] http://cygwin.com/ml/cygwin-xfree/2011-07/msg00041.html
> >>[2] http://cygwin.com/ml/cygwin/2011-07/msg00308.html
> >>
> >>Jon TURNEY (2):
> >> Push the implementation of defaultTrust() down from the PickView
> >> class to packagedb class
> >> When packages are selected on the command line in unattended mode,
> >> just install those packages
> >>
> >> PickView.cc | 28 ++++------------------------
> >> choose.cc | 30 ++++++++++++++++++++++++++++--
> >> package_db.cc | 43 ++++++++++++++++++++++++++++++++++++++++++-
> >> package_db.h | 5 +++++
> >> 4 files changed, 79 insertions(+), 27 deletions(-)
> >
> >are you planning to follow up on this? If you're happy with your
> >changes, feel free to check them in, regardless of my comment.
>
> Patches applied.
>
> Yes, I was thinking of taking another look at this if and when my time permits.
Cool, thanks.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat