This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup.exe build instructions outdated; build doesn't bootstrap cleanly


On Thu, Jan 17, 2013 at 05:22:33PM +0000, Jon TURNEY wrote:
>On 14/09/2012 01:43, Warren Young wrote:
>> On 9/13/2012 5:09 AM, Jon TURNEY wrote:
>>> On 13/09/2012 03:23, Warren Young wrote:
>>>> 5. Several build system files refer to iniparse.h, but on my system,
>>>> iniparse.yy yields iniparse.hh, not .h.
>>>
>>> See the note on a "Slightly backward-incompatible change" in the section
>>> "Changes to Yacc and Lex support" in [1]
>> 
>> Lovely.
>> 
>> I don't see a clean solution short of demanding that everyone be on Automake
>> 1.12 then.  Symlink hackery only works when you know which versino of Automake
>> you are running.  I guess bootstrap.sh could detect Automake 1.11 and below,
>> but ick.
>
>Indeed.
>
>Attached is a patch which fixes things for and requires automake >=1.12.
>
>(Note that automake has some magic to select the version of automake which was
>previously run in a directory, rather than just selecting the latest version
>installed, so you'll need to distclean or 'WANT_AUTOMAKE=1.12 ./bootstrap.sh'
>to build in an already configured directory after applying this patch)
>

>From 478c40eeaa5d6fda2f527072863b5f393ffeca2a Mon Sep 17 00:00:00 2001
>From: Jon TURNEY <jon.turney@dronecode.org.uk>
>Date: Thu, 17 Jan 2013 15:13:11 +0000
>Subject: [PATCH] Require automake 1.12 for consistent naming of generated
> file
>
>Automake <=1.11 and >=1.12 have different behaviour (.h vs .hh) for naming the
>C++ header file generated from a .yy file.
>
>Adapt for the the behaviour of automake 1.12, and require it.
>
>2013-01-17  Jon TURNEY  <jon.turney@dronecode.org.uk>
>
>	* configure.in: Require automake 1.12.
>	* Makefile.am (BUILT_SOURCES): Update iniparse.h to iniparse.hh.
>	* iniparse.yy: Ditto.
>	* inilex.ll: Ditto.

Go ahead and check in.  Thanks.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]