This is the mail archive of the
mailing list for the Cygwin project.
Re: x86/ -> ./ symlink
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Mon, 1 Jul 2013 20:02:25 +0200
- Subject: Re: x86/ -> ./ symlink
- References: <20130629175908 dot GA5778 at ednor dot casa dot cgf dot cx> <20130630093846 dot GA2000 at calimero dot vinschen dot de> <20130630223132 dot GA5077 at ednor dot casa dot cgf dot cx> <20130701092301 dot GD2000 at calimero dot vinschen dot de> <20130701111532 dot GA20414 at calimero dot vinschen dot de> <20130701114624 dot GE2000 at calimero dot vinschen dot de> <20130701125056 dot GF2000 at calimero dot vinschen dot de> <20130701151815 dot GA4763 at calimero dot vinschen dot de> <20130701164017 dot GB4763 at calimero dot vinschen dot de> <87li5qdxdp dot fsf at Rainer dot invalid>
- Reply-to: cygwin-apps at cygwin dot com
On Jul 1 19:05, Achim Gratz wrote:
> Corinna Vinschen writes:
> > + if (--level >= 0)
> > + Find(".").accept(found_ini, 2); // Only search one level deep.
> If you would use post-decrement, then that comment would be a bit less
> puzzling (after the change of 2->1), I'd think.
No, that's a bug. It should visit two levels (./$target, ./$url/$target).
I started with one level but then screwed up. Thanks for catching.
> The change itself breaks a few cases that maybe aren't supported,
> but nevertheless worked for quite some time.
Just to be clear, the introduction of the target subdirs broke any
former working scenario to install from a local dir, be it a mirror or a
setup.exe install dir. Both of these cases should work again (assuming
the above is fixed).
I'm not aware of any other scenario besides ./$target and ./$url/$target
we will have to support. Can you give a brief outline of the scenarios
which aren't supported anymore from your POV?
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com