This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libgetopt++; change DefaultFormatter to produce less line breaks in usage output


On Aug 11 21:08, Achim Gratz wrote:
> 
> The default formatter splits the line 40/40, which produces several
> unnecessary linebreaks for setup.exe and clutters the usage output.
> Implement a 35/45 split by default and provide an alternative
> constructor that enables adjustment of these parameters if necessary.
> 

> >From 4989f5b105875e635b6043f0c306601ca4bec21d Mon Sep 17 00:00:00 2001
> From: Achim Gratz <...>
> Date: Sat, 10 Aug 2013 15:05:30 +0200
> Subject: [PATCH] split line 35/45 by default to have less linebreaks

I'm a bit puzzled.  Why do I always see the mail header twice, once
as mail header and once in the body when you send a patch?  This is
irritating.

>       * include/getopt++/DefaultFormatter.h (DefaultFormatter):
>       Introduce private data members and use them, adjust comment
>       accordingly.  Split the line 35/45 instead of 40/40 by default
>       to get less linebreaks.  Add default initializers for data
>       members to the constructor.  Add a second constructor that
>       offers parameters for initialization of the private data
>       members.
>       (DefaultFormatter::operator ()): Remove automatic variable
>       output and directly put the data on the output stream instead.
>       Use private data members to construct the output rather than
>       magic constants.

Applied.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpYukSJ21E4G.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]