This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Do not clear the prev, curr and exp fields of packagemeta. Never.


On 04/05/2016 13:38, Houder wrote:
Please, submit this patch.

Thanks for the patch.

This patch rectifies

 - packagemeta::ScanDownloadedFiles (package_meta.cc), and
 - packagemeta::trustp (package_meta.h)

Clarification:
Class packagemeta has "fields" prev, curr, exp and installed, which in fact
represent the info from setup.ini/installed.db, and should never be cleared
therefore. _Currently_ these fields are cleared in ScanDownloadedFiles() in
order to notify that the tarball for the associated field is not available.
This is a mistake, as it destroys relevant info (e.g. the version number of
a version).
To ascertain whether or not the associated tarball is available, one should
invoke <field>.accesible().

Can you clarify a bit about the problem that this patch solves? And how you tested that it fixes it?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]