This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

From: Ken Brown <kbrown at cornell dot edu>
To: cygwin-apps at cygwin dot com
Date: Mon, 27 Nov 2017 17:19:57 -0500
Subject: Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting
Authentication-results: sourceware.org; auth=none
References: <20171127213547.10816-1-kbrown@cornell.edu>

On 11/27/2017 4:35 PM, Ken Brown wrote:

The ExtraKeysSetting destructor called UserSettings::set() on a string
that was terminated by LF instead of NUL.  This led to garbage at the
end of the "extrakeys" setting that was written into setup.rc.  Fix
this by replacing the final LF by NUL before calling set().

Disregard this for now. I've just discovered some further issuesinvolving "extrakeys", and I'd like to fix them all at once.

Ken

Follow-Ups:
- Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting
  - From: Ken Brown

References:
- [PATCH setup] Don't write garbage into the "extrakeys" user setting
  - From: Ken Brown

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]