Re: [PATCH setup] Throw exceptions instead of exiting with error codes

[Ken Brown <kbrown at cornell dot edu>]

On 12/20/2017 11:06 AM, Jon Turney wrote:
> On 19/12/2017 17:20, Ken Brown wrote:
> > ---
> >   Exception.h |  1 +
> >   PickView.cc | 11 +++++++----
> >   choose.cc   |  7 +++++--
> >   3 files changed, 13 insertions(+), 6 deletions(-)
>
> Yeah, silently dying seems like a bad idea.
>
> Hmmm... does this not need a corresponding use of TOPLEVEL_CATCH to 
> transform that exception into a fatal() ?

It's already caught by a TOPLEVEL_CATCH.

> In any case, some commentary in the commit about how these exceptions 
> are expected to be handled would good.

Revised patch attached.

Ken

Attachment: 0001-Throw-exceptions-instead-of-exiting-with-error-codes.patch
Description: Text document