This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] Fix handling of '+' by 'cygcheck -p'


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=a15297381df27a5e53eab42fe5c475e2aa55f559

commit a15297381df27a5e53eab42fe5c475e2aa55f559
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Mon Jan 30 15:04:28 2017 +0000

    Fix handling of '+' by 'cygcheck -p'
    
    The form data sent to the server should be application/x-www-form-urlencoded
    
    This replaces spaces with '+' before being RFC 1738 encoded, so a literal
    '+' must be %-encoded also.
    
    See https://cygwin.com/ml/cygwin/2014-01/msg00287.html et seq.
    
    Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>

Diff:
---
 winsup/utils/cygcheck.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/utils/cygcheck.cc b/winsup/utils/cygcheck.cc
index d1e27b7..e745b20 100644
--- a/winsup/utils/cygcheck.cc
+++ b/winsup/utils/cygcheck.cc
@@ -2009,8 +2009,8 @@ check_keys ()
   return 0;
 }
 
-/* RFC1738 says that these do not need to be escaped.  */
-static const char safe_chars[] = "$-_.+!*'(),";
+/* These do not need to be escaped in application/x-www-form-urlencoded */
+static const char safe_chars[] = "$-_.!*'(),";
 
 /* the URL to query.  */
 static const char base_url[] =


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]