This is the mail archive of the cygwin-developers@sourceware.cygnus.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: cygwin_bind bug.


On Thu, Nov 25, 1999 at 11:28:38AM +0900, Kazuhiro Fujieda wrote:
>>>> On Wed, 24 Nov 1999 20:56:52 -0500
>>>> Chris Faylor <cgf@cygnus.com> said:
>
>> In that case, why even use an intermediate variable?  Why not just check
>> the results from bind and getsockname directly?
>
>There is no reason... I carelessly failed to notice there is
>no need of it.
>
>> Index: net.cc
>...
>>            else
>>              {
>>                _close (fd);
>>                chmod (un_addr->sun_path,
>>                  (S_IFSOCK | S_IRWXU | S_IRWXG | S_IRWXO) & ~myself->umask);
>> -              res = 0;
>>              }
>
>It is overkill. No one can set `res' to 0.

Hmm.  I wonder how I deleted that line.  The 'goto out' below it is also overkill.

cgf

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]