This is the mail archive of the
cygwin-developers@sourceware.cygnus.com
mailing list for the Cygwin project.
Re: cygwin-src-20000125: patch to not convert cmdline to OEM
- To: Corinna Vinschen <corinna at vinschen dot de>
- Subject: Re: cygwin-src-20000125: patch to not convert cmdline to OEM
- From: Chris Faylor <cgf at cygnus dot com>
- Date: Tue, 15 Feb 2000 19:08:56 -0500
- Cc: cygwin-developers at sourceware dot cygnus dot com, Reinhard Nissl <rnissl at gmx dot de>
- References: <38A6E0D9.442DD5E9@gmx.de> <20000214165303.A18925@cygnus.com> <38A9E4AF.5E7C26BF@vinschen.de>
- Reply-To: cygwin-developers at sourceware dot cygnus dot com
On Wed, Feb 16, 2000 at 12:43:43AM +0100, Corinna Vinschen wrote:
>Chris Faylor wrote:
>> On Sun, Feb 13, 2000 at 05:50:33PM +0100, Reinhard Nissl wrote:
>> >the attached patch makes cygwin1.dll only convert the cmdline to OEM when the
>> >environment variable CYGWIN_CMD_LINE_MODE is not set to ANSI. If the variable
>> >doesn't exist or is set to anything else then ANSI, the library behaves as it
>> >did before applying the patch.
>> > [...]
>> I have a few problems with this patch.
>> [...]
>> 4) I am wondering if the conditional behavior of this code should actually be
>> the default behavior, i.e., should we always be using SetFileApisToANSI and
>> MultiByteToWideChar.
>>
>> 1 - 3 are obviously easy to fix but I'd like to get a better feel for 3.
4.