Re: ANONYMOUS_STRUCT/UNION in w32api

[Christopher Faylor <cgf at redhat dot com>]

On Wed, Apr 18, 2001 at 07:49:21PM -0400, Christopher Faylor wrote:
>On Wed, Apr 18, 2001 at 07:45:35PM -0400, Earnie Boyd wrote:
>>Christopher Faylor wrote:
>>> 
>>> On Thu, Apr 19, 2001 at 12:52:22AM +0200, Corinna Vinschen wrote:
>>> >The latest change to w32api related to the ANONYMOUS_STRUCT and
>>> >ANONYMOUS_UNION problem breaks applications which doesn't include
>>> ><windows.h> but all needed header files separately. Each of the
>>> >affected files should be able to define that stuff by themselves.
>>> >
>>> >May I suggest creating a new header, say "anon.h", which contains
>>> >that stuff and is included by all affected files? Or, maybe it's
>>> >only at the wrong place and could be moved to, say winnt.h?
>>> 
>>> Maybe we need something more generic.  Linux has something like
>>> features.h but we obviously can't use that name.
>>> 
>>
>>It's a bug in cinstall source.  I've sent a patch.
>
>Why is it a bug?  It's been working for a year.
>
>You should be able to include individual header files.

Nevermind.  I just looked at the way cygwin does this. The windows.h
is needed.

So, I think your patch is right except that the changelog is missing
function names where appropriate.

Could you check your patch, with items like this:

       * choose.cc (create_listview): Clean up type mismatch problems.

rather than

       * choose.cc: Clean up type mismatch problems.

?

cgf