This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: tty patch check in
- From: Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
- To: Steve O <bub at io dot com>
- Cc: cygwin-developers at cygwin dot com
- Date: Sun, 24 Nov 2002 21:27:24 -0500 (EST)
- Subject: Re: tty patch check in
- Reply-to: cygwin-developers at cygwin dot com
On Sat, 23 Nov 2002, Steve O wrote:
> On Sat, Nov 23, 2002 at 03:09:59PM -0500, Christopher Faylor wrote:
> > It needs more testing from more parties. It would be nice if someone
> > like Egor could review the code, too.
>
> My understanding of the process was that changes would be committed
> to CVS then tested by the development community. I think there's
> ample evidence that the patch doesn't cause immediate failure that
> would preclude developers from testing it. If you really want
> more testing, checking it into CVS is the way to do it.
I agree. In the meantime, I can still try to produce the relevant
snapshot for people to try. However, your patch has diverged slightly
from the CVS HEAD revision (I had 4 chunks moved, and one rejected).
Should I try to fix up the patch, or would you like to regenerate it
against the CVS HEAD and submit the new patch (or send it to me off-list)?
Igor
> > My problem with changes this major is that eventually next week, or next
> > year, Corinna and I will end up supporting it.
>
> True, so how can I make the code easier for you to support?
> I can introduce fixes in small chunks, that eventually
> add up to what we have now. Would that be better?
>
> > I hope I can get your committment that you will be actively
> > involved in supporting the code for at least a few months after it goes
> > in.
>
> I don't foresee this being a problem.
> -- steve
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51