This is the mail archive of the cygwin-patches@sourceware.cygnus.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: preliminary patch2 for i18n: change the code page to ANSI.


>>> On Tue, 04 Jul 2000 12:59:50 +0200
>>> Corinna Vinschen <vinschen@cygnus.com> said:

> Only one thing: Did you notice the use of OemToChar() in
> security.cc::read_sd()?
> It was necessary to get GetFileSecurity() working with umlauts.
> 
> Shouldn't this be changed then, too?

Yes, it should be changed. I failed to include the change of
security.cc in my previous mail. Thank you for your notice.

ChangeLog:
2000-07-04  Kazuhiro Fujieda  <fujieda@jaist.ac.jp>

	security.cc (read_sd): Eliminate OemToChar.

Index: security.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/security.cc,v
retrieving revision 1.11
diff -u -p -r1.11 security.cc
--- security.cc	2000/07/02 10:17:44	1.11
+++ security.cc	2000/07/04 13:54:13
@@ -487,9 +487,7 @@ read_sd(const char *file, PSECURITY_DESC
   debug_printf("file = %s", file);
 
   DWORD len = 0;
-  char fbuf[PATH_MAX];
-  OemToChar(file, fbuf);
-  if (! GetFileSecurity (fbuf,
+  if (! GetFileSecurity (file,
                          OWNER_SECURITY_INFORMATION
                          | GROUP_SECURITY_INFORMATION
                          | DACL_SECURITY_INFORMATION,

____
  | AIST      Kazuhiro Fujieda <fujieda@jaist.ac.jp>
  | HOKURIKU  School of Information Science
o_/ 1990      Japan Advanced Institute of Science and Technology

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]