This is the mail archive of the cygwin-patches@sources.redhat.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

cygcheck patch (updated)


I forgot to mention that I tested this on both Win98 and NT4, gcov
reported 80% code coverage with my test cases. I ran the test cases on the
old version and the new version, comparing the output (which was the same,
save the timestamp printed and the path to the executable). The timings
(using time) is about the same.

Test cases were:
1. cygcheck (no args)
2. cygcheck -h -v -s -r
3. cygcheck -v -h -k (press lotsa keys, then q)


Changelog:

2000-12-07  Matt Hargett  <matt@use.net>

	* utils/cygcheck.cc (keyeprint): Moved declaration before other
	functions so it could be used by all functions to report error
	messages. Added comment.

	(add_path): Initial uses of pointers are now checked for
	NULL. This includes pointers from malloc() and pointers 
 	passed as parameters.

	(find_on_path): Ditto.

	(rva_to_offset): Ditto.

	(init_paths): Added checking for return values of Win32 calls.

	(get_dword): Ditto.

	(get_word): Ditto.

	(dll_info): Ditto, also NULL pointer checks.

	(scan_registry): Ditto.

	(check_keys): Ditto.

        (dump_sysinfo): Ditto. Added default case to switch. Added error
	reporting if GetVolumeInformation fails, except when it
	returns ERROR_NOT_READY. ERROR_NOT_READY is returned when
	removeable drives are empty.

	(track_down): Added checking for NULL pointers and 
	return values of Win32 calls. Corrected small memory leak.

cygcheck.cc-patch.gz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]