This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Move per_thread::set() def from fork.cc to perthread.h


On Sun, Oct 14, 2001 at 11:10:54AM -0500, Gary R. Van Sickle wrote:
>[snip]
>
>> >The idea isn't to get it into the header, but rather to get it out of
>> >fork.cc, where it doesn't belong.  Currently, there is no 
>> perthread.cc; the
>> >entire per_thread class is implemented in the header.  I agree, 
>> there's most
>> >likely no reason this shouldn't be in a .cc file.
>> 
>> I agree with Robert that putting this is in the header doesn't seem like
>> the right thing to do.  It's in fork.cc primarily because I wanted it
>> to be in a .cc file for debugging purposes.
>
>Ah, good point.  Do you have any objections then to a perthread.cc?

I guess not in principle but it seems kind of pointless for one
function.  And, it would be enough of a patch that I'd need an
assignment from you.  I don't think we have an assignment on file from
you, do we?

I'm actually thinking that maybe it *should* just live in the header.
I think I might have moved it to fork.cc when I was debuging it.

cgf 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]