This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] setup.exe: Stop NetIO_HTTP from treating entire stream as a header


> >Ah, better yet.  Jeez you guys are clever ;-).  But how
> about we make it:
> >
> >	while (((l = s->gets ()) != 0) && (*l != '\0'))
> >
> >in the interest of making it a bit more self-documenting?
>
> Actually, how about not using != 0.  Use NULL in this context.
>

Also better yet.

> I don't think that *l is hard to understand, fwiw.
>

Right, it isn't.  I did need to do a double-take though at this ungodly hour
of the afternoon, whereas the '\0' would have reduced that to a single-take
;-).

--
Gary R. Van Sickle
Braemar Inc.
11481 Rupp Dr.
Burnsville, MN 55337


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]