This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: /proc and /proc/registry
On Mon, Feb 25, 2002 at 09:07:10PM -0000, Chris January wrote:
>> Please resubmit your patch against current CVS sources.
>Please find patch against today's CVS attached.
Ok. Preliminary comments.
1) The copyrights still need to be changed.
2) The code formatting still is not correct.
3) You have a lot of calls to normalize_posix_path. Is that really
necessary? It seems to be called a lot. If it is really necessary,
I'd prefer that it just be called in dtable::build_fhandler and made
the standard "unix_path_name".
4) Could you generate the diff using 'cvs diff -up"
I haven't applied the patch to test it yet. Anyone else interested in
doing this?
cgf