This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mkgroup usage/version patch


On Wed, Mar 13, 2002 at 01:26:32PM -0800, Joshua Daniel Franklin wrote:
> This patch generalizes the usage function to allow output to stdout in
> addition to stderr, and fixes an apparent typo where the help option
> is listed as -?,--help, while in reality the code supports -h,--help.
> It also adds a -v,--version option with Chris' print_version function.

While I'm going with the decision to add a version information
I don't understand why you changed 

- the usage output method.  I don't like to have a big multiline format
  string in fprintf.

- the function usage() to exit instead of returning the exitcode.

I don't see an advantage and I'd like you to keep the patch less
intrusive if possible.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]