This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: Readv/writev patch
- From: Corinna Vinschen <cygwin-patches at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Wed, 28 Aug 2002 12:37:35 +0200
- Subject: Re: Readv/writev patch
- References: <01aa01c24dda$cc5384b0$6132bc3e@BABEL>
On Tue, Aug 27, 2002 at 04:02:43PM +0100, Conrad Scott wrote:
> I've tried to reduce the size of the patch by sending in some
> unrelated parts over the last couple of days but I realize that
> this is still quite large. If you'ld like me to split the patch
> up (e.g. into the base fhandler part and the socket part), give me
> a call and I'll see if I can find the energy to do so; London's
Yes, please. Especially I'm reluctant to introduce your changes
to the sendto and recvfrom implementation since I know there is
a good reason to use the WinSock1 calls in the non-blocking case
even though I don't recall why, right now. Please skip that
beautyifing patches and just add the readv/writev functionality.
I've just checked in a patch which adds SIGPIPE handling to
sendto(). I'd appreciate if you could take this into account.
I also don't like these C++ cast operators since the Plain-C casts
are doing quite the same but are way easier to read. Perhaps I'm
just old-fashioned.
And as you said, I think it would be wise to split the fhandler_base
from the fhandler_socket part.
Other than that it looks like a good patch.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.