This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [franck.leray@cheops.fr: tcsetattr timeout problem ?]


On Fri, Aug 30, 2002 at 10:12:36PM +0400, egor duda wrote:
>ed> Actually, the patch is wrong :(. I'm looking into it and post a
>ed> correct one asap.
>
>Forgot to include fhandler_tty.cc part.
>
>Please check it if possible and feel free to apply it, as i will be
>away from computer for some time.

I took a look at your patch but it didn't seem right to me.

You were asking about circumventing the 'ready_for_read' code and,
since fhandler_tty_slave::read has the ability to detect a signal,
removal of fhandler_tty_slave::ready_for_read is the right way to
go, AFAICT.  So, I did that.

That meant that I just had to get rid of the

  if (vmin == 0)
    time_to_wait == INFINITE

lines in fhandler_tty::ready_for_read, for things to work correctly.
I wrote a test program and it worked the same way on linux and
cygwin after my patch.

Thanks for looking into this.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]