Re: [PATCH] fhandler_tty deadlock patch

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On Mon, 21 Oct 2002, Igor Pechtchanski wrote:

> On Mon, 21 Oct 2002, Steve O wrote:
>
> > On Sun, Oct 20, 2002 at 11:15:47PM -0400, Igor Pechtchanski wrote:
> > > /bin/sh ignores Enter (or ^J, or ^M).
> >
> > Good find.  I've attached a diff that should fix this.  Unsure
> > how to proceed since the original patch hasn't been applied.
> > Do I resubmit the original patch or treat this one as it's own
> > thing?
>
> Thanks, I'll try it out and let you know if it works for me.

Steve,

Ok, here goes:
If a command is typed, the first Enter is still ignored, the second is
accepted, the command is executed, and then the shell exits (see
steve_o-paste-sh.strace, the command typed was 'ls').
If no command is typed, Enter exits the shell (see
steve_o-paste-sh1.strace).
Some more info: a lone Enter now kills cat as well.  Strace attached
(see steve_o-paste-cat.strace, the characters typed were
'a<Space><Enter>b<Enter><Enter>').
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51

Attachment: steve_o-paste-sh.strace.bz2
Description: Binary data

Attachment: steve_o-paste-sh1.strace.bz2
Description: Binary data

Attachment: steve_o-paste-cat.strace.bz2
Description: Binary data