This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] - tc{set,get}attr() error checking and B0 support


On Wed, Jan 22, 2003 at 05:34:36PM -0700, Troy Curtiss wrote:
>Per your comments on my prior patches, I have re-architected my
>error-checking changes so that the short-circuiting behavior in
>tcsetattr() is gone.  I also cleaned up the B0 (ie.  drop DTR) support
>to more closely resemble what POSIX expects while not enraging Win32 :)
>Please let me know if this passes muster - the prior test case program
>still applies.

I think the patch has nearly reached the size where an assignment is
required but since most of it is reformatting, I'll let it slide.

Rather than explicitly setting errno to EINVAL, the code had been
previously setting the errno based on the error reported by Windows.  I
don't see any reason to stop doing that.  It will probably default to
EINVAL anyway, but, if it doesn't, then a more explicit errno is
probably better.

Anyway, I'll check this in with some formatting and other stylistic
tweaks.

Thanks and sorry for the delay in reviewing this.
cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]