This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] updated pthread list patch


I'm happy with changing the method naming format, but is it GNU
standard? Thats a requirement for the cygwin project.

http://www.gnu.org/prep/standards_26.html#SEC26 says that 
"For example, you should use names like ignore_space_change_flag; don't
use names like iCantReadThis."

Now, I happen to disagree with the GNU conventions here, particularly as
they don't have a C++ section (and C doesn't have the same degree of
name space conflicts that C++ does) :}. But, the pthread code should
stay within the GNU guidelines.

So, I'm sorry to have you jumping through hoops, but can you please
change your patch so that all new methods use the GNU convention here.

Other than that, please apply it.
Rob
-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]