This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygcheck: don't fail integrity check on empty package


On Fri, 5 Sep 2003, Christopher Faylor wrote:

> On Fri, Sep 05, 2003 at 08:53:54PM -0400, Igor Pechtchanski wrote:
> >On Fri, 5 Sep 2003, Igor Pechtchanski wrote:
> >>This patch fixes the erroneous failure of "cygcheck -c" when the
> >>package is empty (and thus the file list for it is missing), e.g.,
> >>XFree86-base.
> >
> >Sorry, I've messed up the ChangeLog entry.  The correct one is included
> >below.
> >
> >>==============================================================================
> >>ChangeLog:
> >2003-09-05 Igor Pechtchanski <pechtcha@cs.nyu.edu>
> >
> >* dump_setup.cc (check_package_files): Don't fail on empty package.
>
> I'll check this in but I wonder if the printfs here shouldn't be fprintf(stderr
> since they are sort of an error condition.
>
> cgf

Perhaps, but they are only printed if verbose output is requested, so
presumably the user wants to see them on stdout.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]