This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: dtable.cc typo


On Tue, Nov 11, 2003 at 06:08:08PM -0600, Brian Ford wrote:
>I don't know c++ much/at all, but this looks wrong to me.  I don't
>understand how it even compiled before?  Feel free to slap me in the face
>because you can switch on a struct in c++? :)
>
>2003-11-11  Brian Ford  <ford@vss.fsi.com>
>
>	* dtable.cc (build_fh_pc): Fix typo in device number switch.

Not a problem.

struct device
{
  .
  .
  .
  inline operator int () const {return devn;}
  .
  .
  .
}

cgf

>Index: dtable.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/dtable.cc,v
>retrieving revision 1.119
>diff -u -p -r1.119 dtable.cc
>--- dtable.cc	1 Oct 2003 12:36:39 -0000	1.119
>+++ dtable.cc	11 Nov 2003 22:08:59 -0000
>@@ -340,7 +340,7 @@ build_fh_pc (path_conv& pc)
> 	fh = cnew (fhandler_dev_tape) ();
> 	break;
>       default:
>-	switch (pc.dev)
>+	switch (pc.dev.devn)
> 	  {
> 	  case FH_CONSOLE:
> 	  case FH_CONIN:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]