This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FW: Final patch for audio recording with /dev/dsp


[Sorry for the delay, I didn't realize that my mail to cygwin-patches
 didn't come through]

Hi Gerd,

thanks for the patch, but regardless of the content, it's not acceptable
for a few stylistic reasons:

- All sentences end in a full stop in the ChangeLog.

- Could you please change all one line if expressions like this:

    if (head_ == depth1_) head_ = 0;

  to

    if (head_ == depth1_)
      head_ = 0;

- Please change `*(buffer+1)' to `*(buffer + 1)'.

- Please change

    do {
      blah;
    } while (foo);

  to

    do
      {
        blah;
      }
    while (foo);

  This is also written in the first form in other files but those are files
  taken from other sources, not genuine Cygwin files.

- One line comments using C++-comment style (//) are ok, but it would be
  nice, if you could convert multiline comments to this

    /* This is a 
       multiline comment. */

  style.  I know that the surrounding code doesn't always adhere to that
  rule, but I'd not be unhappy if you would change these comments as well.


But the biggest possible favor you could do us is, to send patches in
clear text, not uuencoded or zipped.  Attachments or inline are both ok,
the ChangeLog is inline most welcome.  Clear text patches allow to discuss
issues online easily and one doesn't have to unpack a patch just for being
able to look into it.


Thanks,
Corinna


On Feb 29 22:02, Gerd Spalink wrote:
> Hello,
> 
> Please find attached the patch updated against current CVS.
> It replaces the patch posted on Feb 7, 2003.
> It has been created from the directory src/winsup (paths are relative from there)
> 
> The third attachment is the test that on my system resides in directory
> src/winsup/testsuite/winsup.api
> to make it part of the testsuite. On my system (Win2000, on board AC97 audio),
> it works fine stand-alone and as part of "make check". It takes 16.4 seconds to complete
> and emits some beeping noises on the speakers.
> 
> Best regards
> 
> Gerd

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]