This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: Correct debugging output in seteuid32
- From: "Pierre A. Humblet" <pierre at phumblet dot no-ip dot org>
- To: Kazuhiro Fujieda <fujieda at jaist dot ac dot jp>,cygwin-patches at cygwin dot com
- Date: Thu, 14 Apr 2005 16:24:24 -0400
- Subject: Re: Correct debugging output in seteuid32
I can see why would one think this is a bug, but it was meant
to be that way. Having a "wrong" gid can make seteuid fail.
Perhaps we could print the new and current uids and the current
gid to cover all cases.
Pierre
At 01:59 PM 4/14/2005 +0900, Kazuhiro Fujieda wrote:
>I'd submit a trivial patch after a long time.
>
>2005-04-14 Kazuhiro Fujieda <fujieda@jaist.ac.jp>
>
> * syscalls.cc (setuid32): Correct debugging output.
>
>Index: syscalls.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/syscalls.cc,v
>retrieving revision 1.372
>diff -u -u -r1.372 syscalls.cc
>--- syscalls.cc 11 Apr 2005 21:54:54 -0000 1.372
>+++ syscalls.cc 14 Apr 2005 04:45:38 -0000
>@@ -1959,7 +1959,7 @@
> extern "C" int
> seteuid32 (__uid32_t uid)
> {
>- debug_printf ("uid: %u myself->gid: %u", uid, myself->gid);
>+ debug_printf ("uid: %u myself->uid: %u", uid, myself->uid);
>
> if (uid == myself->uid && !cygheap->user.groups.ischanged)
> {
>
>____
> | AIST Kazuhiro Fujieda <fujieda@jaist.ac.jp>
> | HOKURIKU School of Information Science
>o_/ 1990 Japan Advanced Institute of Science and Technology
>
>