This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Allow access to /proc/registry/HKEY_PERFORMANCE_DATA


On Fri, Dec 19, 2008 at 1:58 PM, Christian Franke  wrote:
>        (fhandler_registry::fill_filebuf): Use larger buffer to speed up
>        access to HKEY_PERFORMANCE_DATA values.  Remove check for possible
>        subkey.  Add RegCloseKey ().

+      /* RegQueryValueEx () opens HKEY_PERFORMANCE_DATA.  */
+      RegCloseKey (handle);

I'm slightly puzzled by this change. handle is usually closed in
fhandler_register::close. If you close it here then won't CloseHandle
be called with an invalid handle in that method?

Chris


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]