This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: sleep/nanosleep bug


On Nov 25 06:11, Eric Blake wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> According to Eric Blake on 11/20/2009 7:15 AM:
> >>> 	* signal.cc (nanosleep): Support 'infinite' sleep times.
> >>> 	(sleep): Avoid uninitialized memory.
> >> Sorry but, while I agree with the basic idea, this seems like
> >> unnecessary use of recursion.  It seems like you could accomplish the
> >> same thing by just putting the cancelable_wait in a for loop.  I think
> >> adding recursion here obfuscates the function unnecesarily.
> > 
> > How about the following, then?  Same changelog.
> 
> Ping.

Do you think we need it in 1.7.1?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]