This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Sun, 13 Mar 2011 16:21:11 +0100
- Subject: Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()
- References: <4D7CDDC7.5060708@dronecode.org.uk>
- Reply-to: cygwin-patches at cygwin dot com
Hi Jon,
On Mar 13 15:07, Jon TURNEY wrote:
>
> Attached is a patch which avoids a fork failure due to remap error in the
> specific circumstances described in my email [1], by adding an additional pass
> to load_after_fork() which forces the DLL to be relocated by VirtualAlloc()ing
> a block of memory at the load address as well.
>
> Hopefully it can be seen by inspection that this code doesn't change the
> behaviour of the first two passes, and so will only be changing the behaviour
> in what was an fatal error case before.
Thanks for the patch, but afaics you don't have a copyright assignment
on file with Red Hat. It's unfortunately required for substantial
patches. Please see http://cygwin.com/contrib.html, especially the
"Before you get started" section.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat