This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] implement /proc/sysvipc/*
On Apr 1 11:34, Christopher Faylor wrote:
> On Fri, Apr 01, 2011 at 12:05:56PM +0200, Corinna Vinschen wrote:
> >Chris, do you think there's anything speaking against rearranging this
> >so that the FH_FS and FH_NETDRIVE definitions are separate from the
> >stuff under /proc? Or, hang on, we should change all PROC values,
> >along these lines:
> >
> > FH_FS = FHDEV (0, 247), /* filesystem based device */
> > FH_NETDRIVE= FHDEV (0, 246),
> > FH_DEV = FHDEV (0, 245),
> >
> > FH_PROC = FHDEV (0, 244),
> > FH_REGISTRY= FHDEV (0, 243),
> > FH_PROCESS = FHDEV (0, 242),
> > FH_PROCNET = FHDEV (0, 241),
> > FH_PROCESSFD = FHDEV (0, 240),
> > FH_PROCSYS = FHDEV (0, 239),
> > FH_PROCSYSVIPC = FHDEV (0, 238),
> >
> > FH_PROC_MIN_MINOR = FHDEV (0, 200), /* Arbitrary value */
> >
> >Then we can simplify the isproc_dev definition like this:
> >
> >#define isproc_dev(devn) \
> > (devn >= FH_PROC_MIN_MINOR && devn <= FH_PROC)
> >
> >Does that sound ok?
>
> Yes. I was, for a while, trying to keep the device numbers the same as
> Linux but I don't think that even applies in this case.
Cool, thanks.
Yaakov, would you mind to apply youir patch with this change?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat