This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: Improvements to fork handling (3/5)
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Sat, 28 May 2011 16:59:27 -0400
- Subject: Re: Improvements to fork handling (3/5)
- References: <4DCAD629.8010803@cs.utoronto.ca>
- Reply-to: cygwin-patches at cygwin dot com
On Wed, May 11, 2011 at 02:32:09PM -0400, Ryan Johnson wrote:
>This patch fixes a bug in the reserve_at function which caused it to
>sometimes reserve space needed by the dll it was supposed to help land.
>This happens when the dll tries to land in a free region which overlaps
>the desired location. The new code exploits the image introspection
>(patch #2) to get the dll's image size and avoids the corner cases.
I've installed this patch, eliminating any depencencies on patch 2/5.
Btw, please reread the guidelines for ChangeLogs and model your changelog
entries on what you see in the current ChangeLog and the submissions you
see here.
The ChangeLog shouldn't be sent as an attachment. It should have the
"header" including your name and date. The tense shouldn't be "Changed
x" but "Change X". Start entries after the colon with an uppercase
letter. The changelog shouldn't be excessively wordy (that's for
comments:
http://www.gnu.org/prep/standards/html_node/Change-Logs.html
Thanks for the patch.
cgf